Files
faceclaw/app/phone-ui
Chris Lee ec12a4845b Fix onboarding firmware-check: kind mismatch broke every real result
classifyOnboardingFirmware() (firmware-compat.ts) returns kind values of
"custom" | "flashable-stock" | "newer-stock" | "unknown", but
applyClassification()'s switch (onboarding-firmware-check-view-model.ts)
checked for "flashable" / "newer" -- names borrowed from the unrelated
CheckPhase type used a few lines later via setPhase(). Since kind was
typed as plain string, nothing caught the mismatch at compile time.

Effect: any device that successfully reported a firmware version (stock,
flashable-stock, or newer-stock alike) fell through to the switch's
default case and showed "Connected, but couldn't read a firmware
version" -- the hard-block message meant for when the probe gets no
data at all. Confirmed on real hardware (glasses on 2.2.9.22): the BLE
probe read the version correctly every time, logged it correctly, and
the UI still reported it as unreadable.

Fix: match the real OnboardingFirmwareKind strings, and tighten the
parameter's type from `string` to `OnboardingFirmwareKind` so this
category of typo fails to compile instead of failing silently.
2026-08-30 10:19:35 -04:00
..