forked from Blendman974/faceclaw
<details>
<summary>Prompts Used</summary>
Let's add a Permissions screen, to concentrate the various Android permissions requests. This will be shown during onboarding, in between the "Before You Continue" screen and the "Custom Firmware Required" screen. There will also be a "Permissions" menu item in the main screen menu.
Each permission will be a card, styled similarly to the device-selection cards on the Pair Your Glasses screen. Each card will have the title for the permission, some text explaining what the permission is used for, and a checkmark if the permission is already present. The permissions needed are:
Nearby Devices: Needed to communicate with your smart glasses over bluetooth
Send Notifications: A notification will be pinned, to keep Faceclaw running while your phone screen is off.
Battery Optimization: Needed to keep running while your phone screen is off.
Read Notifications: (Optional) Needed to display your Android notification on the glasses.
Microphone: (Optional) Needed to use voice input.
Location: (Optional) Needed to use location-based features like navigation inside glasses apps.
Calendar: (Optional) Needed to display your calendar on the glasses.
> Done — the Permissions screen is in place, builds cleanly, and all the permissions it requests were already declared in the manifest.
>
> **What was added:**
>
> - **New screen** (`app/phone-ui/permissions-page.{xml,ts}` + `permissions-view-model.ts`): one card per permission, reusing the pairing page's card styling (`pairing-row`, `pairing-title`, `pairing-badge`) so they match the device-selection cards. Each card shows the title, the explanation text you specified, and a green ✓ when granted. Tapping an ungranted card launches its grant flow; granted cards ignore taps. The four optional permissions get an "Optional" badge (matching the pairing page's badge style) instead of a "(Optional)" text prefix.
> - **Onboarding wiring**: "Agree" on Before You Continue now navigates to the permissions page, and its "Next" button navigates forward to a fresh onboarding page starting at the Custom Firmware Required step (`onboarding-page.ts` now accepts a `step` context; `OnboardingViewModel` takes an initial step). "Back" returns to the disclaimer.
> - **Main menu**: a "Permissions" popup item on the main page opens the same screen in standalone mode — action bar shown, single "Done" button.
> - **Permission plumbing** (`app/g2/android-permissions.ts`): new granular helpers — `hasBlePermissions`/`requestBlePermissions` (BLE only, split out of the old combined BLE+notifications request), `hasPostNotificationsPermission`/`requestPostNotificationsPermission` (reports granted pre-Android 13, where no runtime permission exists), and `hasMicrophonePermission`/`requestMicrophonePermission`. Existing `ensureBlePermissions` behavior is unchanged for its current callers.
>
> Two of the cards — Battery Optimization and Read Notifications — aren't runtime permissions; they open system screens (the existing `battery-optimization.ts` and `notification-access.ts` natives). Since Android reports their state only on return, the page re-checks all statuses on `Application.resume` (listener attached on page load, detached on unload) so checkmarks appear when you come back.
>
> Two judgment calls worth flagging: the Location checkmark tracks **fine** location (navigation needs precise fixes — "approximate only" leaves it unchecked and re-tappable), and I wrote "your Android notifications" (plural) in the Read Notifications card. This is all hardware-test pending, as usual — the flows to exercise are onboarding step 2 → Permissions → step 3, each card's grant dialog, and the resume-refresh after the battery/notification-access settings detours.
<hr>
Thanks. Let's make it so that the Continue button looks grayed out if you haven't selected all of the required permissions. It will still be active in this case, but will open a "You haven't enabled all of the necessary permissions. Are you sure you want to continue?" prompt. Also, let's add 8px of extra margin between the permission titles and the Optional badge.
> Both changes are in and the build passes.
>
> - **Grayed-out Continue**: the onboarding primary button now binds a `primaryClass` — while any of the three required permissions (Nearby Devices, Send Notifications, Battery Optimization) is missing, it gets a `permissions-primary-dimmed` class (opacity 0.45) so it looks disabled while staying tappable. Tapping it in that state shows a confirm dialog — "You haven't enabled all of the necessary permissions. Are you sure you want to continue?" with Continue/Go Back buttons — and only proceeds to the firmware step on Continue. The class re-evaluates on every refresh, so granting the last required permission un-dims the button immediately. I also renamed the onboarding label from "Next" to "Continue" to match how you referred to it (and the pairing page's onboarding button). Menu mode's "Done" never dims, since there's nothing to warn about when just closing the screen.
> - **Badge spacing**: the "Optional" badge's left margin went from the `m-l-6` class to an explicit `marginLeft="14"` (+8), set inline since the theme doesn't generate an `m-l-14` class.
</details>
244 lines
8.0 KiB
TypeScript
244 lines
8.0 KiB
TypeScript
import { Application, Dialogs, EventData, Frame, Observable, View } from "@nativescript/core";
|
|
|
|
import {
|
|
ensureCalendarPermission,
|
|
ensureFineLocationPermission,
|
|
hasBlePermissions,
|
|
hasCalendarPermission,
|
|
hasFineLocationPermission,
|
|
hasMicrophonePermission,
|
|
hasPostNotificationsPermission,
|
|
requestBlePermissions,
|
|
requestMicrophonePermission,
|
|
requestPostNotificationsPermission,
|
|
} from "../g2/android-permissions";
|
|
import { isIgnoringBatteryOptimizations, requestIgnoreBatteryOptimizations } from "../native/battery-optimization";
|
|
import { isNotificationListenerEnabled, requestNotificationListenerAccess } from "../native/notification-access";
|
|
|
|
type PermissionDefinition = {
|
|
id: string;
|
|
title: string;
|
|
description: string;
|
|
optional: boolean;
|
|
isGranted: () => boolean;
|
|
/** Show the grant UI: a runtime-permission dialog or a system settings screen. */
|
|
request: () => void | Promise<unknown>;
|
|
};
|
|
|
|
/**
|
|
* Battery Optimization and Read Notifications are not runtime permissions:
|
|
* their request() opens a system screen, so the granted state can only be
|
|
* re-checked when the app resumes (the page refreshes on Application.resume).
|
|
*/
|
|
const PERMISSIONS: PermissionDefinition[] = [
|
|
{
|
|
id: "nearby-devices",
|
|
title: "Nearby Devices",
|
|
description: "Needed to communicate with your smart glasses over Bluetooth.",
|
|
optional: false,
|
|
isGranted: hasBlePermissions,
|
|
request: requestBlePermissions,
|
|
},
|
|
{
|
|
id: "post-notifications",
|
|
title: "Send Notifications",
|
|
description: "A notification will be pinned, to keep Faceclaw running while your phone screen is off.",
|
|
optional: false,
|
|
isGranted: hasPostNotificationsPermission,
|
|
request: requestPostNotificationsPermission,
|
|
},
|
|
{
|
|
id: "battery-optimization",
|
|
title: "Battery Optimization",
|
|
description: "Needed to keep running while your phone screen is off.",
|
|
optional: false,
|
|
isGranted: isIgnoringBatteryOptimizations,
|
|
request: requestIgnoreBatteryOptimizations,
|
|
},
|
|
{
|
|
id: "read-notifications",
|
|
title: "Read Notifications",
|
|
description: "Needed to display your Android notifications on the glasses.",
|
|
optional: true,
|
|
isGranted: isNotificationListenerEnabled,
|
|
request: requestNotificationListenerAccess,
|
|
},
|
|
{
|
|
id: "microphone",
|
|
title: "Microphone",
|
|
description: "Needed to use voice input.",
|
|
optional: true,
|
|
isGranted: hasMicrophonePermission,
|
|
request: requestMicrophonePermission,
|
|
},
|
|
{
|
|
id: "location",
|
|
title: "Location",
|
|
description: "Needed to use location-based features like navigation inside glasses apps.",
|
|
optional: true,
|
|
// Navigation needs precise fixes, so the checkmark tracks fine location;
|
|
// "approximate only" leaves the card unchecked and re-tappable.
|
|
isGranted: hasFineLocationPermission,
|
|
request: ensureFineLocationPermission,
|
|
},
|
|
{
|
|
id: "calendar",
|
|
title: "Calendar",
|
|
description: "Needed to display your calendar on the glasses.",
|
|
optional: true,
|
|
isGranted: hasCalendarPermission,
|
|
request: ensureCalendarPermission,
|
|
},
|
|
];
|
|
|
|
/** One Repeater card: the permission's copy plus the display-only fields the XML binds. */
|
|
export type PermissionCardItem = {
|
|
id: string;
|
|
title: string;
|
|
description: string;
|
|
optionalVisibility: "visible" | "collapse";
|
|
checkVisibility: "visible" | "collapse";
|
|
onCardTap: (args: EventData) => void;
|
|
};
|
|
|
|
/**
|
|
* The Permissions screen: one card per Android permission Faceclaw uses, with
|
|
* a checkmark when it is already granted and tap-to-grant otherwise. Reached
|
|
* both from onboarding (between the disclaimer and the firmware step) and from
|
|
* the main-screen menu.
|
|
*/
|
|
export class PermissionsViewModel extends Observable {
|
|
private readonly onboarding: boolean;
|
|
private _cards: PermissionCardItem[] = [];
|
|
private requesting = false;
|
|
|
|
constructor(options?: { onboarding?: boolean }) {
|
|
super();
|
|
this.onboarding = options?.onboarding ?? false;
|
|
this.refresh();
|
|
}
|
|
|
|
/**
|
|
* Battery Optimization and Read Notifications grant flows leave the app for
|
|
* a system screen; re-check everything whenever the app comes back.
|
|
*/
|
|
private readonly onAppResume = (): void => this.refresh();
|
|
|
|
onPageLoaded(): void {
|
|
Application.on(Application.resumeEvent, this.onAppResume);
|
|
this.refresh();
|
|
}
|
|
|
|
onPageUnloaded(): void {
|
|
Application.off(Application.resumeEvent, this.onAppResume);
|
|
}
|
|
|
|
// --- observable properties -------------------------------------------------
|
|
|
|
get actionBarHidden(): boolean {
|
|
return this.onboarding;
|
|
}
|
|
|
|
get headlineVisibility(): "visible" | "collapse" {
|
|
return this.onboarding ? "visible" : "collapse";
|
|
}
|
|
|
|
get instructions(): string {
|
|
return this.onboarding
|
|
? "Faceclaw uses these Android permissions. Tap a card to grant one; a checkmark means it is already granted. " +
|
|
"Optional permissions can also be granted later, from the Permissions item in the main-screen menu."
|
|
: "Tap a card to grant a permission; a checkmark means it is already granted.";
|
|
}
|
|
|
|
get cards(): PermissionCardItem[] {
|
|
return this._cards;
|
|
}
|
|
|
|
get primaryLabel(): string {
|
|
return this.onboarding ? "Continue" : "Done";
|
|
}
|
|
|
|
/**
|
|
* Continue looks grayed out (but stays tappable — tapping it asks for
|
|
* confirmation instead) while a required permission is missing. Done, in
|
|
* menu mode, never dims: there is nothing to warn about when closing.
|
|
*/
|
|
get primaryClass(): string {
|
|
return this.onboarding && !this.requiredPermissionsGranted()
|
|
? "-primary permissions-primary-dimmed"
|
|
: "-primary";
|
|
}
|
|
|
|
get secondaryVisibility(): "visible" | "collapse" {
|
|
return this.onboarding ? "visible" : "collapse";
|
|
}
|
|
|
|
// --- actions ---------------------------------------------------------------
|
|
|
|
// Arrow property: NativeScript fires XML event handlers with `this` bound to
|
|
// the tapped view's bindingContext (the card item), not the view model.
|
|
readonly onCardTap = (args: EventData): void => {
|
|
const item = (args.object as View).bindingContext as PermissionCardItem | undefined;
|
|
if (!item || this.requesting) return;
|
|
const definition = PERMISSIONS.find((permission) => permission.id === item.id);
|
|
if (!definition || definition.isGranted()) return;
|
|
void this.requestPermission(definition);
|
|
};
|
|
|
|
async onPrimaryTap(): Promise<void> {
|
|
if (this.onboarding) {
|
|
if (!this.requiredPermissionsGranted()) {
|
|
const proceed = await Dialogs.confirm({
|
|
title: "Missing Permissions",
|
|
message: "You haven't enabled all of the necessary permissions. Are you sure you want to continue?",
|
|
okButtonText: "Continue",
|
|
cancelButtonText: "Go Back",
|
|
});
|
|
if (!proceed) return;
|
|
}
|
|
// Continue the onboarding chain at the Custom Firmware Required step.
|
|
Frame.topmost()?.navigate({
|
|
moduleName: "phone-ui/onboarding-page",
|
|
context: { step: 3 },
|
|
});
|
|
return;
|
|
}
|
|
Frame.topmost()?.goBack();
|
|
}
|
|
|
|
onSecondaryTap(): void {
|
|
Frame.topmost()?.goBack();
|
|
}
|
|
|
|
// --- rendering -------------------------------------------------------------
|
|
|
|
private async requestPermission(definition: PermissionDefinition): Promise<void> {
|
|
this.requesting = true;
|
|
try {
|
|
await definition.request();
|
|
} catch {
|
|
// A denial simply leaves the card unchecked; the user can tap again.
|
|
} finally {
|
|
this.requesting = false;
|
|
this.refresh();
|
|
}
|
|
}
|
|
|
|
private requiredPermissionsGranted(): boolean {
|
|
return PERMISSIONS.every((definition) => definition.optional || definition.isGranted());
|
|
}
|
|
|
|
refresh(): void {
|
|
this._cards = PERMISSIONS.map((definition) => ({
|
|
id: definition.id,
|
|
title: definition.title,
|
|
description: definition.description,
|
|
optionalVisibility: definition.optional ? "visible" : "collapse",
|
|
checkVisibility: definition.isGranted() ? "visible" : "collapse",
|
|
onCardTap: this.onCardTap,
|
|
}));
|
|
this.notifyPropertyChange("cards", this._cards);
|
|
this.notifyPropertyChange("primaryClass", this.primaryClass);
|
|
}
|
|
}
|