Files
faceclaw/tests/flash-prompt-fallback.test.cjs
T
JMO a7916a5479 Make the firmware upgrade reachable from older custom firmware
Glasses running an older Faceclaw firmware revision cannot be upgraded at all.
The flash asks for confirmation on the lens first, and that firmware never
shows the prompt, so the one path off it is closed. Measured on revision 13
(base 2.2.9.22).

showPrompt writes the EvenHub create-prompt page to the right arm and waits for
an ack. The lens accepts the write at the GATT layer and then answers nothing
and displays nothing: four attempts, four onWriteCharacteristic status=0
length=165, no reply. buildCreatePromptPage documents its geometry as
stock-firmware-safe "so this works before flashing", and that does not hold
there.

Three faults, each only visible once the previous one is fixed.

An unacked prompt page was fatal. Flashing is the only way off that firmware,
so failing here leaves the glasses permanently unupgradable. An unacked page
now falls back to the phone-side confirmation that the low-battery retry
already uses, on a screen that says what is being given up: the on-lens step is
what proves the glasses are the wearer's.

connectArm made a single attempt. The lens is routinely unavailable for a
moment just after a previous link to it closed, which is exactly the state a
retry is in, so the fallback failed instantly with "could not connect to the
right arm". FaceclawFirmwareFlasher.connectLensResilient already retries within
a window for this reason; connectArmResilient mirrors it and reports each
attempt.

That retry then tripped the lost-connection latch. Disconnecting between
attempts fires onConnectionStateChange, which set rightLost AND finished and
counted down the selection latch, so a successful second attempt still aborted
with "Lost connection to the glasses". The callback now ignores drops while the
arms are still being established.

Logging, because a failed flash used to leave almost nothing to read. emitLog
reached logcat, but emitState, emitProgress and emitComplete on the flasher,
and emitState and emitResult on the prompt communicator, went only to the
in-app listener, so the line carrying the reason existed only on the phone
screen. Seven `catch (Exception ignored)` blocks across the two classes now log
with the Throwable, matching the call sites elsewhere that already do.

tests/flash-prompt-fallback.test.cjs covers the decision at its seam through
the existing load-typescript loader. The first test fails against the current
view model and passes with this change; the second is a regression guard and
passes either way, so an unrelated failure cannot quietly skip the on-lens
confirmation.

Verified on hardware: both lenses flashed through this path after it had been a
dead end.
2026-09-22 22:09:11 -07:00

63 lines
3.2 KiB
JavaScript

// The flash cannot always ask for confirmation on the lens: firmware older than
// the revision this build needs accepts the create-prompt write and then never
// answers it. Flashing is the only way off that firmware, so an unacked prompt
// must not be a dead end. These cover the decision at that seam.
const test = require('node:test');
const assert = require('node:assert/strict');
const { loader } = require('./helpers/load-typescript.cjs');
function fixture() {
class Observable { notifyPropertyChange() {} }
const load = loader({}, {
'@nativescript/core': { Observable, Frame: { topmost: () => null } },
'./onboarding-navigation': { finishOnboardingNavigation() {} },
'./onboarding-state': { setOnboardingCompleted() {}, setPreviewOnlyMode() {} },
'../native/ble-permissions': { ensureBlePermissions: async () => {} },
'../g2/device-addresses': {
isValidMacAddress: () => true,
loadDeviceAddresses: () => ({ right: 'R', left: 'L' }),
saveDeviceAddresses() {},
},
'../g2/firmware-builder': {
buildCustomFirmware: async () => '', buildStockFirmware: async () => '',
FirmwareBuildError: class extends Error {}, FirmwareProgress: {},
},
'../native/device-discovery': { buildAddressSet: () => new Set(), DeviceDiscoveryBridge: class {} },
'../native/firmware-flasher': { FirmwareFlasher: class {} },
'../native/flash-prompt-communicator': { FlashPromptCommunicator: class {} },
'../g2/reconnect-policy': { resumeAutoReconnect() {}, suppressAutoReconnect() {} },
'../util/format-error': { formatErrorMessage: (e) => String(e) },
});
const mod = load('app/phone-ui/onboarding-flash-view-model.ts');
const Model = mod.OnboardingFlashViewModel ?? Object.values(mod).find((v) => typeof v === 'function');
const model = new Model();
const beginArgs = [];
model.beginPrompt = async (options) => { beginArgs.push(options); };
return { model, beginArgs };
}
test('an unacked prompt page offers the phone-side confirmation instead of dead-ending', () => {
const { model, beginArgs } = fixture();
model.handlePromptState('error', 'prompt page not acked: AA:BB:CC:DD:EE:FF', false);
assert.equal(model.phase, 'error');
assert.equal(model.headline, 'Confirm On Your Phone');
assert.equal(model.primaryLabel, 'Confirm & Install', 'the action is a confirmation, not a retry');
assert.match(model.status, /can't show the confirmation prompt/i);
model.retryAction();
// The loader runs the module in its own vm realm, so the options object has that
// realm's prototype and deepStrictEqual would reject it. Compare the field.
assert.equal(beginArgs.length, 1);
assert.equal(beginArgs[0].skipPrompt, true, 'confirming must skip the lens prompt, not re-ask for it');
});
test('any other prompt failure still reports as an ordinary retry', () => {
const { model, beginArgs } = fixture();
model.handlePromptState('error', 'discoverServices failed: right arm', false);
assert.equal(model.phase, 'error');
assert.equal(model.headline, 'Something Went Wrong');
assert.equal(model.primaryLabel, 'Retry');
model.retryAction();
assert.equal(beginArgs.length, 1);
assert.equal(beginArgs[0].skipPrompt, false, 'an ordinary failure must not silently skip the lens prompt');
});