Commit Graph
114 Commits
Author SHA1 Message Date
James Babcock eef7aa2679 <details>
<summary>Prompts Used</summary>
Act as a code reviewer for https://github.com/jimrandomh/faceclaw/pull/14 (checked out in this working directory).

> * The review finished — 42 raw candidates were verified down to 10 confirmed findings. Reporting them now.
>
> * Code review(review · 10 findings)
>   ⎿  app/phone-ui/main-view-model.ts
>        ●  766 [correctness]   mirrorFraction subtracts view.getLocationOnScreen() from tap coordinates that NativeScript already delivers
>                               view-local, so every phone-mirror tap is shifted up/left and misroutes
>        ●   84 [resource-leak] MainViewModel's constructor registers onAnySettingChanged and discards the unsubscriber; a new view model is
>                               built on every page navigation, leaking listeners and retained preview bitmaps
>      wear/app/src/main/kotlin/com/faceclaw/wear/MainActivity.kt
>        ●   52 [correctness]   onStop abandons an in-progress stem-button hold without sending LONG_PRESS_RELEASE, so the glasses shell
>                               escape menu opens by itself
>      wear/app/src/main/kotlin/com/faceclaw/wear/ui/TouchpadGestures.kt
>        ●   62 [correctness]   Breaking out of the touchpad gesture loop on a consumed pointer event (or coroutine cancellation mid-hold)
>                               skips onLongPressEnd, leaving a stuck long-press
>      wear/app/src/main/kotlin/com/faceclaw/wear/PhoneLink.kt
>        ●  270 [correctness]   loadStateItem queries the Data Layer with a hostless Uri (`wear:/faceclaw/state`), which matches no stored
>                               items, so the cached phone state is never read
>      app/ui/shell/modal-layer.ts
>        ●   14 [correctness]   MODAL_INTERIOR is a module-level constant frozen at import time from the (now runtime-dynamic) display mode,
>                               while modalRect() is computed live, so modals render corrupted after a display-mode switch
>      app/g2/dashboard-controller.ts
>        ● 1404 [correctness]   handleMirrorTouch wakes the glasses display unconditionally, bypassing the watchWakesDisplaySetting gate
>                               that the parallel injectSyntheticRingInput path honors
>        ● 1440 [correctness]   A mirror tap while any second layer is stacked (e.g. an in-window long-press menu) degrades to a blind
>                               synthetic click that activates whatever is highlighted, not what was tapped
>      App_Resources/Android/src/main/java/com/faceclaw/app/FaceclawWearBridge.java
>        ●  147 [correctness]   Watch gestures/commands queued while the JS listener is down are replayed up to 30 seconds later on listener
>                               registration, executing stale non-idempotent input the watch already reported as failed
>      wear/app/src/main/kotlin/com/faceclaw/wear/ui/RemoteScreen.kt
>        ●  232 [efficiency]    WristTwistDetector (gyroscope, default-on) samples at 100 Hz via DisposableEffect and is not stopped when
>                               the activity stops, draining the watch battery while the process is cached
>
> * Review of PR #14 (Wear OS companion app + remote controls, 85 files, +5813/−102) is done — 10 confirmed findings reported above, ranked by
>   severity. The headline items are the phone-mirror tap coordinate double-correction (which misroutes every mirror tap in the default
>   configuration) and two independent paths on the watch that can drop LONG_PRESS_RELEASE, each of which makes the shell escape menu open on the
>   glasses by itself.
>
> A few things beyond the reported list, for context:
>
> Refuted during verification (looked like bugs, aren't): the watch ack-timeout-during-render theory (input injection never blocks on BLE
> transmit), mirror swipes stealing page scroll (no enclosing ScrollView), and a suspected raw-settings-key notification gap (the store-level
> broadcast covers raw keys).
>
> Confirmed but below the 10-finding cap — worth folding in if you're touching those areas anyway:
> - shell.closeAssistant() no-ops via popIfTop when another layer sits above the assistant, yet still acks ok to the watch.
> - Landscape preview sizing still assumes the old 260-wide panel after the XML moved to 360 (overlap under ~568 dip).
> - The shell escape menu and tool-debug dialogs hardcode SIDEBAR_WIDTH + 8, wrong in the new full-panel mode.
> - A CapabilityClient IPC fires every 250 ms during streamed assistant replies even on watchless phones; backgrounded preview updates bypass
>   their 150 ms floor.
> - Cleanups: the sidebarWidth() > 0 || focus === "sidebar" predicate appears three times, sidebar slot math is duplicated in chrome-layer.ts,
>   dead protocol-version plumbing, dead padPointers field, and display-mode is missing from wear/PROTOCOL.md.
>
> If you'd like, I can apply fixes for any subset of these, or post the findings as inline PR comments (/code-review 14 --comment).

<hr>

Thanks, let's go ahead and write fixes for all of the issues you described.

> Everything builds and tests pass. All 16 issues from the review are fixed — the 10 reported findings plus the six below-cap items. Here's what changed, by fix:
>
> **Watch app (Kotlin)**
> - **Stuck long-press via onStop** — `MainActivity.onStop` now sends `LONG_PRESS_RELEASE` when a stem hold is in progress before dropping the link, so the phone's escape-menu countdown can't run to completion on its own.
> - **Stuck long-press via the gesture loop** — `detectTouchpadGestures` wraps the loop in try/finally that pairs every `onLongPressStart` with an `onLongPressEnd`, covering both the consumed-event `break` and coroutine cancellation mid-hold.
> - **Cached state never loading** — `PhoneLink.loadStateItem` now queries `wear://*/faceclaw/state` (wildcard host) instead of a hostless Uri that matched nothing, so the watch shows the cached dashboard state when the phone is unreachable.
> - **Sensors draining battery while stopped** — the gyroscope/accelerometer/off-body detectors are now driven by a `WhileStartedEffect` helper tied to the activity lifecycle: they stop on `ON_STOP` (palmed screen, back to watch face) and restart on `ON_START`, instead of running at 100 Hz for as long as the process is cached.
> - **Dead protocol plumbing** — removed the unused `Protocol.PROTOCOL_VERSION` const and the never-read `PhoneState.protocol` field; the wire field stays and PROTOCOL.md now documents it as reserved.
>
> **Phone Java**
> - **Stale input replay** — `FaceclawWearBridge` now queues only idempotent `/faceclaw/state/request` messages for replay after the JS listener registers; gestures and commands that arrived while the dashboard was down are acked as failed and dropped, never executed up to 30 seconds later.
>
> **Phone TypeScript**
> - **Mirror taps misrouting (the top finding)** — `mirrorFraction` no longer subtracts `getLocationOnScreen()`; NativeScript's `getX`/`getY` are view-local DIPs (I verified this in the installed `@nativescript/core` gesture source), so every mirror tap was being shifted up-left by the status bar + action bar. Taps now land where you touch.
> - **Mirror touch ignoring the wake setting** — `handleMirrorTouch` now honours `watchWakesDisplaySetting`: with it off, only a double-tap reaches a dark display, matching the rest of the watch scheme.
> - **Blind click through open menus** — `LayerStack.hitTest` now consumes a mirror tap when any layer is stacked (menu, dialog) instead of reporting a miss, so a tap on visible app content can no longer activate whatever menu row happened to be highlighted (e.g. "Close window").
> - **Modal corruption after display-mode switch** — `MODAL_INTERIOR` is now a live `modalInterior()` function, and `ShellModalLayer.paint` re-syncs the inner stack's size each paint, so notification modals render correctly after switching Band ↔ Full panel.
> - **View-model leak** — `MainViewModel` keeps its controller/settings unsubscribers and exposes `attach()`/`dispose()`; `main-page.ts` disposes on unload and re-attaches on load (re-attach is needed because suspend/resume fires unloaded/loaded without a navigation, and `subscribe` delivers a fresh snapshot so nothing is missed).
> - **`closeAssistant` no-op** — new `LayerStack.popThrough` closes the assistant overlay plus anything stacked above it (follow-up voice dialog, alert); the watch ack now says "The assistant was not open." when there was nothing to close.
> - **Watchless-phone IPC churn** — assistant stream events and alerts are skipped when no watch is reachable, so a streaming reply no longer triggers a CapabilityClient lookup every 250 ms.
> - **Backgrounded preview floor bypass** — the 150 ms floor check (and timestamp) in `updateCompositePreview` now runs before the foreground-activity check, so backgrounded per-frame refreshes actually throttle.
> - **Full-panel hardcodes** — the shell escape menu and tool-debug dialogs position at `sidebarWidth() + 8` (0 in full-panel mode) instead of the fixed 64 px strip.
> - **Cleanups** — the strip-visible predicate is now one `sidebarStripVisible()` helper in geometry.ts (used in three places); sidebar slot math is a single `slotPosition()` shared by drawing and hit-testing; dead `padPointers` removed; landscape preview sizing updated to the XML's 360 dp panel; `wear/PROTOCOL.md` documents the `display-mode` command and `displayMode` state field.
>
> Verification: `./build.sh` (webpack + Gradle) succeeds, `npx tsc --noEmit` is clean, the wear `:app:assembleDebug` builds, and all 59 tests pass. The behavioral fixes — especially mirror-tap coordinates, the two long-press-release paths, and the watch state cache — still need a hardware pass to confirm on device.
</details>
2026-08-25 00:09:47 -07:00
James Babcock 646335cb64 Merge branch 'main' of https://github.com/jimrandomh/faceclaw into android-wear-integration
# Conflicts:
#	app/phone-ui/main-page.xml
#	app/phone-ui/main-view-model.ts
2026-08-24 22:24:03 -07:00
James Babcock ab963974e5 Overridden ring long-press handling also applies for the glasses touchpad 2026-08-24 19:23:09 -07:00
James Babcock 208b14e928 Update ACKNOWLEDGEMENTS 2026-08-24 13:17:09 -07:00
James Babcock 92a2530e0e Merge branch 'main' of https://github.com/jimrandomh/faceclaw into android-wear-integration 2026-08-24 00:23:16 -07:00
Kalani Helekunihi 8fa04d1b46 Add Wear OS companion app and remote controls
Add a Wearable Data Layer bridge for syncing dashboard state and commands.

Introduce a standalone watch app with assistant, app launcher, touchpad remote, settings, and connectivity UI.
2026-08-23 15:02:35 -05:00
James Babcock 2b71eddab5 Optimize APK size
Removes unused keyword-spotting model. Makes on-device voice model a
runtime download rather than bundling it. Removes native-code library
versions for 32-bit and x86_64 processors.
2026-08-22 23:04:01 -07:00
James Babcock cc4b69fb80 UI tweaks 2026-08-22 21:53:54 -07:00
James Babcock 35e6977c6c UI refinement pass
Remove gesture-help bottom-bars from many places in the UI, adjust
layouts to be able to handle larger fonts, and other small UI fixes.
2026-08-22 18:48:20 -07:00
James Babcock 92cd05b6ca Add options to load an app from a URL or a QR code
(The QR code reading does not work yet)
2026-08-21 12:03:24 -07:00
James Babcock c27dcacfee Change symbol for tap from U+00B7 (· middle dot) to U+25CF (● black circle) 2026-08-20 10:25:40 -07:00
James Babcock bd5ca21017 Fix a minor glitch in the app-switcher tab border 2026-08-20 10:14:21 -07:00
James Babcock 12bb76ba3c Add calibration options to the compass app 2026-08-20 09:57:33 -07:00
James Babcock f6035ea9ec Performance optimizations 2026-08-20 02:46:03 -07:00
James Babcock eef9fbaab4 Adjust UI to account for user-configured variable font size 2026-08-19 20:48:18 -07:00
James Babcock 96842ceb23 Use TTF fonts throughout the UI; also add some more functions to app extension API 2026-08-19 19:35:24 -07:00
James Babcock deac81f98f EvenHub app uses logo; move login from the Settings app into the EvenHub app 2026-08-19 00:49:18 -07:00
James Babcock 83e0fa919f Use the texture cache to avoid resending icons and font glyphs 2026-08-18 23:39:21 -07:00
James Babcock eab5a17b6d Centralized version number; bump to 0.4.0 2026-08-16 22:38:58 -07:00
James Babcock fdf683761e Apps submit mutli-plane images with glyphs, rather than mere images 2026-08-16 21:01:20 -07:00
James Babcock df85fb4072 Auto-get OpenUdid rather than it being a config setting 2026-08-16 21:01:20 -07:00
James Babcock b86f395866 Add mic support for EvenHub apps 2026-08-16 21:01:20 -07:00
James Babcock add8763028 Even store integration 2026-08-16 21:01:20 -07:00
James Babcock b9f48c8e16 Allow backgrounding EvenHub apps 2026-08-16 20:59:42 -07:00
James Babcock cde29cc4d0 Basic EvenHub store compatibility 2026-08-16 20:59:42 -07:00
James Babcock d7d12afcaa Modify sidebar size and vertical sizing options to allow 576x288 EvenHub apps to fit cleanly 2026-08-11 00:07:14 -07:00
James Babcock 6df7e9bc81 Terminal connection string management, multi-host 2026-08-10 01:47:26 -07:00
James Babcock 6f45888627 Add support for a local model (Qwen3) 2026-08-09 23:52:21 -07:00
James Babcock 2562761038 Terminal auto-reconnect 2026-08-09 16:08:19 -07:00
James Babcock 9ade3503a0 Add a resource-usage monitor to debug app; fix excessive memory-usage from screen preview when not focused 2026-08-07 02:21:24 -07:00
James Babcock b5213170e3 Add link to ACKNOWLEDGEMENTS.md to the Settings app, and update it 2026-08-06 11:10:55 -07:00
James Babcock ba81e46624 Add Soniox as an API speech-to-text option 2026-08-04 20:15:39 -07:00
James Babcock 4022f06d49 Build an integration with Roam Research 2026-08-03 15:21:52 -07:00
James Babcock 63f515b8a6 Minor refactoring 2026-08-03 02:06:01 -07:00
James Babcock 9b3832d7a7 Refactor: Organize files by app 2026-08-03 00:08:52 -07:00
James Babcock 1ec6b3ff83 Crop screenshots 2026-08-02 19:36:16 -07:00
James Babcock 0f4adb0e86 Rename README to README.md 2026-08-02 19:35:36 -07:00
James Babcock 960e2fd6e1 Add a lock screen, controlled by wear-detection 2026-08-02 15:38:07 -07:00
James BabcockandClaude Fable 5 48bac85cbe External assistant backend: agent bridge client + MCP server
Phase 3 of the voice-assistant design: assistant.backend=external routes
utterances over a dial-out websocket to faceclaw-agent-bridge (an OpenClaw
plugin on the user's machine). The phone serves its ToolRegistry as MCP on
the same socket, with proactive gating and rate limiting enforced locally.
New Assistant settings section with backend/bridge settings.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XCdkQyB3RUVPTuEmhxVEdp
2026-08-01 18:28:47 -07:00
James Babcock 474844f961 App-launcher UI: Wrapping, fix a minor folder-selection UI bug 2026-08-01 16:23:52 -07:00
James Babcock 37e95627b1 Add window persistence across app restarts 2026-08-01 15:27:44 -07:00
James Babcock 4d1182599b Add privacy policy; update README; incorporate both into Settings app 2026-07-31 22:19:51 -07:00
James Babcock 65c73ad144 Two-column app switcher 2026-07-31 22:17:31 -07:00
James Babcock 7d2a41bd56 Apps are variable height; add vertical position setting 2026-07-31 14:52:51 -07:00
James Babcock 6d42f0e65e Expand screen resolution to the full 640x480 2026-07-31 12:57:10 -07:00
James Babcock 818f33ce33 Increase screen size a little bit past 576x288, to exercise the corresponding new firmware 2026-07-30 00:45:31 -07:00
James Babcock b738ce4bb2 Add screen-recording option 2026-07-28 10:16:44 -07:00
James Babcock 4c946631e0 Add a pinball game 2026-07-26 21:03:52 -07:00
James Babcock 434419c8e4 Add a minesweeper game, a freecell game, and some voice assistant tools for window management 2026-07-26 19:45:14 -07:00
James Babcock 93d98965de Add support for g2mirror lanuch presets to Terminal app 2026-07-26 14:31:21 -07:00