forked from Blendman974/faceclaw
Merge notification preferences and bulk actions
This commit is contained in:
10 files changed
+263
-13
No files matched your search
@@ -0,0 +1,69 @@
|
||||
const test = require('node:test');
|
||||
const assert = require('node:assert/strict');
|
||||
const { loader } = require('./helpers/load-typescript.cjs');
|
||||
|
||||
test('Notifications menu dismisses all, including beyond the visible list, and leaves filters untouched', () => {
|
||||
let options, active = Array.from({ length: 80 }, (_, i) => ({ key: String(i) }));
|
||||
let dismissals = 0, renders = 0, pops = 0;
|
||||
const load = loader({}, {
|
||||
'../../ui/notifications': { NotificationsListLayer: class {} },
|
||||
'../../ui/notification-filter': { NotificationFilterLayer: class {} },
|
||||
'../../native/notification-icons': {
|
||||
ALL_NOTIFICATIONS: 0x7fffffff,
|
||||
readActiveNotifications(max) { assert.equal(max, 0x7fffffff); return active; },
|
||||
dismissAllNotifications() { dismissals++; active = []; return true; },
|
||||
onAndroidNotificationsChanged: () => () => {},
|
||||
},
|
||||
'../../ui/shell/in-process-window': {
|
||||
YieldAtRootLayer: class {},
|
||||
createInProcessWindow(value) { options = value; return { requestRender() { renders++; } }; },
|
||||
},
|
||||
});
|
||||
load('app/apps/notifications/notifications-app.ts').createNotificationsAppWindow({});
|
||||
const items = options.menuItems();
|
||||
assert.equal(items[0].label, 'Notification filter');
|
||||
const action = items.find(x => x.label === 'Dismiss all notifications');
|
||||
assert.equal(action.disabled(), false);
|
||||
assert.equal(dismissals, 0);
|
||||
action.onSelect({ stack: { pop() { pops++; } } });
|
||||
assert.equal(dismissals, 1);
|
||||
assert.equal(pops, 1);
|
||||
assert.equal(renders, 1);
|
||||
assert.equal(action.disabled(), true);
|
||||
});
|
||||
|
||||
test('Android bulk action uses the native listener and propagates unavailable access', () => {
|
||||
let calls = 0, allowed = false;
|
||||
const load = loader({ global: { isAndroid: true }, com: { faceclaw: { app: {
|
||||
FaceclawMediaNotificationListenerService: { dismissAllNotifications() { calls++; return allowed; } },
|
||||
} } } }, {
|
||||
'../graphics/image': {}, './frame-timings': {}, '../util/array-util': {},
|
||||
'./notification-sources': {}, './image-files': { PHOTO_TONE: { gamma: 1 } }, './notification-types': { NOTIFICATION_ICON_SIZE: 24 },
|
||||
});
|
||||
const api = load('app/native/notification-icons.ts');
|
||||
assert.equal(api.dismissAllNotifications(), false);
|
||||
allowed = true;
|
||||
assert.equal(api.dismissAllNotifications(), true);
|
||||
assert.equal(calls, 2);
|
||||
});
|
||||
|
||||
test('iOS snapshots all ANCS keys and continues when a notification cannot be dismissed', () => {
|
||||
const load = loader({}, {
|
||||
'../graphics/pebble-icons': {}, '../g2/ancs-client': {}, './notification-app-icons': {}, './notification-sources': {},
|
||||
});
|
||||
const api = load('app/native/notification-icons.ios.ts');
|
||||
assert.equal(api.dismissAllNotifications(), false);
|
||||
const active = Array.from({ length: 80 }, (_, i) => ({ key: String(i) })), attempted = [];
|
||||
api.bindIosNotifications({
|
||||
read(max) { assert.equal(max, api.ALL_NOTIFICATIONS); return active; },
|
||||
dismiss(key) {
|
||||
attempted.push(key);
|
||||
if (key === '1') return false;
|
||||
active.splice(active.findIndex(x => x.key === key), 1);
|
||||
return true;
|
||||
},
|
||||
});
|
||||
assert.equal(api.dismissAllNotifications(), false);
|
||||
assert.equal(attempted.length, 80);
|
||||
assert.deepEqual(active, [{ key: '1' }]);
|
||||
});
|
||||
@@ -165,6 +165,7 @@ test('cancel and back dismiss the popup without changing source preferences', as
|
||||
test('filter toggles persist after notifications disappear and discovers new sources while open', async () => {
|
||||
const app = ui();
|
||||
app.paint(app.filter);
|
||||
for (let i = 0; i < 3; i++) await app.input(app.filter, 'scroll-down');
|
||||
await app.input(app.filter, 'click');
|
||||
assert.equal(app.prefs.shouldShowNotificationOnGlasses(mail.packageName), false);
|
||||
app.active([{ packageName: 'com.alpha', appName: 'Alpha' }]);
|
||||
@@ -177,6 +178,68 @@ test('filter toggles persist after notifications disappear and discovers new sou
|
||||
assert.equal(app.prefs.shouldShowNotificationOnGlasses('com.alpha'), true);
|
||||
});
|
||||
|
||||
test('default persists without overwriting explicit choices, including legacy saved sources', () => {
|
||||
const settings = new Map([['notifications.sources', JSON.stringify([
|
||||
{ ...mail, showOnGlasses: true },
|
||||
{ packageName: 'muted', appName: 'Muted', showOnGlasses: false },
|
||||
])]]);
|
||||
let prefs = store(settings);
|
||||
prefs.rememberNotificationSources([{ packageName: 'discovered', appName: 'Discovered' }]);
|
||||
prefs.setNewNotificationAppsEnabledByDefault(false);
|
||||
prefs = store(settings);
|
||||
assert.equal(prefs.newNotificationAppsEnabledByDefault(), false);
|
||||
assert.equal(prefs.shouldShowNotificationOnGlasses(mail.packageName), true);
|
||||
assert.equal(prefs.shouldShowNotificationOnGlasses('muted'), false);
|
||||
assert.equal(prefs.shouldShowNotificationOnGlasses('discovered'), false);
|
||||
assert.equal(prefs.shouldShowNotificationOnGlasses('future'), false);
|
||||
prefs.rememberNotificationSources([{ packageName: 'future', appName: 'Future' }]);
|
||||
prefs.setNotificationSourceEnabled({ packageName: 'future', appName: 'Future' }, true);
|
||||
prefs.setNewNotificationAppsEnabledByDefault(true);
|
||||
prefs.setNewNotificationAppsEnabledByDefault(false);
|
||||
assert.equal(store(settings).shouldShowNotificationOnGlasses('future'), true);
|
||||
});
|
||||
|
||||
test('bulk choices persist for known sources without changing the default for future sources', () => {
|
||||
const settings = new Map();
|
||||
let prefs = store(settings);
|
||||
prefs.rememberNotificationSources([mail]);
|
||||
prefs.setAllNotificationSourcesEnabled(false);
|
||||
prefs = store(settings);
|
||||
assert.equal(prefs.shouldShowNotificationOnGlasses(mail.packageName), false);
|
||||
assert.equal(prefs.shouldShowNotificationOnGlasses('future'), true);
|
||||
prefs.setNewNotificationAppsEnabledByDefault(false);
|
||||
prefs.setAllNotificationSourcesEnabled(true);
|
||||
prefs = store(settings);
|
||||
assert.equal(prefs.shouldShowNotificationOnGlasses(mail.packageName), true);
|
||||
assert.equal(prefs.shouldShowNotificationOnGlasses('future'), false);
|
||||
prefs.rememberNotificationSources([{ packageName: 'future', appName: 'Future' }]);
|
||||
assert.equal(prefs.shouldShowNotificationOnGlasses('future'), false);
|
||||
prefs.setAllNotificationSourcesEnabled(false);
|
||||
assert.ok(prefs.readNotificationSources().every(source => !source.showOnGlasses));
|
||||
});
|
||||
|
||||
test('filter controls work with an empty list and keep selection as sources arrive', async () => {
|
||||
const app = ui();
|
||||
app.active([]);
|
||||
const labels = app.paint(app.filter).texts.map(({ text }) => text);
|
||||
assert.ok(labels.includes('New apps enabled by default'));
|
||||
assert.ok(labels.includes('Enable all'));
|
||||
assert.ok(labels.includes('Disable all'));
|
||||
await app.input(app.filter, 'click');
|
||||
assert.equal(app.prefs.newNotificationAppsEnabledByDefault(), false);
|
||||
app.active([mail]);
|
||||
app.paint(app.filter);
|
||||
assert.equal(app.prefs.shouldShowNotificationOnGlasses(mail.packageName), false);
|
||||
await app.input(app.filter, 'scroll-down');
|
||||
await app.input(app.filter, 'click');
|
||||
assert.equal(app.prefs.shouldShowNotificationOnGlasses(mail.packageName), true);
|
||||
assert.equal(app.prefs.newNotificationAppsEnabledByDefault(), false);
|
||||
await app.input(app.filter, 'scroll-down');
|
||||
await app.input(app.filter, 'click');
|
||||
assert.equal(app.prefs.shouldShowNotificationOnGlasses(mail.packageName), false);
|
||||
assert.equal(app.dismissals(), 0);
|
||||
});
|
||||
|
||||
test('popup action wraps fully and stays visible with small and large fonts', async () => {
|
||||
for (const size of [12, 20]) {
|
||||
const app = ui(size);
|
||||
|
||||
Reference in new issue
Block a user