Files app: Gamma correct and dither images when viewing

This commit is contained in:
James Babcock committed 2026-09-01 21:17:42 -07:00
1 parent a72e29a04f
commit c364099a8c
6 files changed
+85 -28

No files matched your search

@@ -205,11 +205,11 @@ public class FaceclawMediaController {
* Album art for the active session's current item, grayscale, scaled to
* fit within maxSize x maxSize preserving aspect. Returns a gray packet
* (see ImageFileLoader.bitmapToGrayPacket) or an empty array when no art
* is available. Cover art is continuous-tone, so it is tone-mapped by
* gamma and dithered onto the display's 16 levels rather than rounded
* per pixel.
* is available. gamma and dither are the photographic tone handling
* described on ImageFileLoader.bitmapToGrayPacket; the TS side passes
* its shared photo preset.
*/
public byte[] getAlbumArtGray(int maxSize, float gamma) {
public byte[] getAlbumArtGray(int maxSize, float gamma, boolean dither) {
Bitmap art;
synchronized (lock) {
if (activeController == null) {
@@ -227,7 +227,7 @@ public class FaceclawMediaController {
art = metadata.getBitmap(MediaMetadata.METADATA_KEY_DISPLAY_ICON);
}
}
return ImageFileLoader.bitmapToGrayPacket(art, maxSize, maxSize, gamma, true);
return ImageFileLoader.bitmapToGrayPacket(art, maxSize, maxSize, gamma, dither);
}
/**
@@ -8,7 +8,9 @@ import android.util.Log;
* Decodes image files (and bitmaps generally) to the grayscale packet format
* used across the TS bridge: [widthLo, widthHi, heightLo, heightHi,
* pixels...] with one byte per pixel, row-major, or an empty array on
* failure. FaceclawMediaController's album art shares bitmapToGrayPacket.
* failure. FaceclawMediaController's album art shares bitmapToGrayPacket;
* the TS side (app/native/image-files.ts) owns the shared photo-tone preset
* passed as (gamma, dither).
*/
public final class ImageFileLoader {
private static final String TAG = "ImageFileLoader";
@@ -17,9 +19,21 @@ public final class ImageFileLoader {
/**
* Decode an image file and downscale it to fit within maxWidth x
* maxHeight, preserving aspect ratio and never upscaling.
* maxHeight, preserving aspect ratio and never upscaling. Flat
* conversion (no tone curve, per-pixel rounding): right for UI raster
* such as icons.
*/
public static byte[] loadGray(String path, int maxWidth, int maxHeight) {
return loadGray(path, maxWidth, maxHeight, 1f, false);
}
/**
* As above, with the photographic tone handling described on
* bitmapToGrayPacket(Bitmap, int, int, float, boolean): use for
* continuous-tone images (photos) viewed on the glasses.
*/
public static byte[] loadGray(
String path, int maxWidth, int maxHeight, float gamma, boolean dither) {
if (path == null || maxWidth <= 0 || maxHeight <= 0) {
return new byte[0];
}
@@ -43,7 +57,7 @@ public final class ImageFileLoader {
if (bitmap == null) {
return new byte[0];
}
return bitmapToGrayPacket(bitmap, maxWidth, maxHeight);
return bitmapToGrayPacket(bitmap, maxWidth, maxHeight, gamma, dither);
} catch (Exception | OutOfMemoryError e) {
Log.w(TAG, "image decode failed: " + path, e);
return new byte[0];
@@ -56,6 +70,12 @@ public final class ImageFileLoader {
* ByteBuffer because NativeScript marshals a JS ArrayBuffer to one.
*/
public static byte[] loadGrayFromBytes(java.nio.ByteBuffer buffer, int maxWidth, int maxHeight) {
return loadGrayFromBytes(buffer, maxWidth, maxHeight, 1f, false);
}
/** As above, with photographic tone handling (see bitmapToGrayPacket). */
public static byte[] loadGrayFromBytes(
java.nio.ByteBuffer buffer, int maxWidth, int maxHeight, float gamma, boolean dither) {
if (buffer == null || maxWidth <= 0 || maxHeight <= 0) {
return new byte[0];
}
@@ -71,7 +91,7 @@ public final class ImageFileLoader {
if (bitmap == null) {
return new byte[0];
}
return bitmapToGrayPacket(bitmap, maxWidth, maxHeight);
return bitmapToGrayPacket(bitmap, maxWidth, maxHeight, gamma, dither);
} catch (Exception | OutOfMemoryError e) {
Log.w(TAG, "byte-array image decode failed", e);
return new byte[0];