This commit is contained in:
James Babcock committed 2026-09-22 21:40:55 -07:00
commit 92e8def0f0
3 files changed
+175 -7

No files matched your search

+126
View File
@@ -0,0 +1,126 @@
// The EvenHub sign-in form's open/close contract, which is what made it
// impossible to get rid of: it used to open itself on the store layer's first
// paint (which includes the restore of a still-open EvenHub at startup), and
// submitting an untouched form reopened it, so with no Cancel control on the
// panel there was no way out.
//
// The real store layer runs here with its dependencies mocked, so these assert
// the layer's actual behavior rather than a reimplementation of it.
const test = require('node:test');
const assert = require('node:assert/strict');
const { loader } = require('./helpers/load-typescript.cjs');
const setting = (initial = '') => {
let value = initial;
return { get: () => value, set: (next) => { value = next; } };
};
/** Load the store layer with a signed-out account and no stored credentials. */
const loadStoreLayer = () => {
const email = setting('');
const password = setting('');
const font = { lineHeight: 10 };
const load = loader({}, {
'../../graphics/ui-fonts': { getDefaultSmallFont: () => font },
'../../graphics/image': { GrayImage: class { drawText() {} } },
'../../graphics/textwrap': { truncateText: (_f, text) => text, wrapText: (_f, text) => [text] },
'../../util/numeric-util': { clamp: (v, lo, hi) => Math.min(hi, Math.max(lo, v)) },
'../../ui/gestures': { GESTURE_CLICK: 'click' },
'../../ui/menu': { drawListScrollbar() {}, drawSelectionHighlight() {}, scrollToKeepSelectionVisible() {} },
'../../ui/shell/shell': { shell: { yieldFocusToSidebar() {} } },
'../../ui/metrics': { lineStep: () => 12 },
'../../ui/dashboard-settings': {
ConfigSettingString: class { constructor(options) { this.value = options.defaultValue ?? ''; }
get() { return this.value; } set(next) { this.value = next; } },
},
'./even-api': {
evenHubApi: { signIn: async () => {} },
EvenHubAuthenticationError: class extends Error {},
isEvenHubStoreConfigured: () => false,
},
'./credentials': {
evenHubLoginEmailSetting: email,
evenHubLoginPasswordSetting: password,
evenHubRememberMeSetting: { get: () => true, set() {} },
clearEvenHubLoginForm() { email.set(''); password.set(''); },
resetEvenHubLoginForm() { email.set(''); password.set(''); },
clearEvenHubSession() {}, clearTransientEvenHubSession() {},
},
'./installed-apps': { getInstalledEvenHubApps: () => [], uninstallEvenHubPackage: async () => {} },
'./store-detail-layer': { EvenHubStoreDetailLayer: class {} },
'./store-install': { cleanError: (error) => String(error), installStoreApp: async () => {} },
'./updates': { checkForEvenHubUpdates: async () => [], describeUpdate: () => '' },
});
const { EvenHubStoreLayer } = load('app/apps/evenhub/store-layer.ts');
return { EvenHubStoreLayer, email, password };
};
/** A LayerContext that records every editor the layer asks the phone to open. */
const makeCtx = () => {
const opened = [];
return {
opened,
stack: { getBaseSize: () => ({ width: 576, height: 136 }) },
actions: {
requestRender() {},
endTextSettingEdit() {},
startTextSettingsEdit(settings, title, onFinish, toggle, onCancel) {
opened.push({ title, onFinish, onCancel });
},
},
};
};
const newLayer = () => {
const { EvenHubStoreLayer } = loadStoreLayer();
return new EvenHubStoreLayer({ launchApp: async () => {}, appendLog: () => {} });
};
const settle = () => new Promise((resolve) => setImmediate(resolve));
test('painting the signed-out store does not open the phone sign-in form by itself', () => {
const layer = newLayer(), ctx = makeCtx();
layer.paint(ctx);
layer.paint(ctx);
assert.deepEqual(ctx.opened, [], 'first paint runs on app-start restore too, so it must not open the editor');
});
test('a click on the login pane opens the sign-in form', () => {
const layer = newLayer(), ctx = makeCtx();
layer.paint(ctx);
layer.handleInput({ type: 'click' }, ctx);
assert.equal(ctx.opened.length, 1);
assert.equal(ctx.opened[0].title, 'Sign in to EvenHub');
assert.equal(typeof ctx.opened[0].onCancel, 'function', 'the editor must hand back a way to close it');
});
test('submitting an untouched sign-in form closes it instead of reopening it', async () => {
const layer = newLayer(), ctx = makeCtx();
layer.paint(ctx);
layer.handleInput({ type: 'click' }, ctx);
ctx.opened[0].onFinish();
await settle();
assert.equal(ctx.opened.length, 1, 'an empty submission is the only way out, so it must not reopen the editor');
});
test('a half-filled sign-in form is a mistake and reopens with the reason', async () => {
const { EvenHubStoreLayer, email } = loadStoreLayer();
const layer = new EvenHubStoreLayer({ launchApp: async () => {}, appendLog: () => {} });
const ctx = makeCtx();
layer.paint(ctx);
layer.handleInput({ type: 'click' }, ctx);
email.set('someone@example.com');
ctx.opened[0].onFinish();
await settle();
assert.equal(ctx.opened.length, 2);
assert.equal(ctx.opened[1].title, 'Sign in to EvenHub');
});
test('cancelling the sign-in form leaves it reopenable', () => {
const layer = newLayer(), ctx = makeCtx();
layer.paint(ctx);
layer.handleInput({ type: 'click' }, ctx);
ctx.opened[0].onCancel();
layer.handleInput({ type: 'click' }, ctx);
assert.equal(ctx.opened.length, 2, 'a dropped onCancel latches the guard and no later open is allowed');
});