forked from Blendman974/faceclaw
feat: configure an independent OpenAI translation model
This commit is contained in:
5 files changed
+52
-9
No files matched your search
@@ -2,7 +2,7 @@ const test = require('node:test');
|
||||
const assert = require('node:assert/strict');
|
||||
const { loader } = require('./helpers/load-typescript.cjs');
|
||||
|
||||
function sharedEnv() {
|
||||
function sharedEnv({ translationModel = '', openAiKey = '', assistantModel = 'openai-compatible' } = {}) {
|
||||
const compatible = [], unexpected = [];
|
||||
const localLlm = {
|
||||
streamLocalModel: () => unexpected.push('local'),
|
||||
@@ -12,11 +12,11 @@ function sharedEnv() {
|
||||
};
|
||||
const settings = {
|
||||
anthropicApiKeySetting: { get: () => '' },
|
||||
assistantModelSetting: { get: () => 'openai-compatible' },
|
||||
assistantModelSetting: { get: () => assistantModel },
|
||||
assistantOpenAiCompatibleUrlSetting: { get: () => 'https://provider.example/api/v1' },
|
||||
assistantOpenAiCompatibleKeySetting: { get: () => 'compatible-key' },
|
||||
assistantOpenAiCompatibleModelSetting: { get: () => 'compatible-model' },
|
||||
openAiApiKeySetting: { get: () => '' },
|
||||
openAiApiKeySetting: { get: () => openAiKey },
|
||||
};
|
||||
const fail = provider => () => { unexpected.push(provider); };
|
||||
const load = loader({ global: { isIOS: false, isAndroid: true } }, {
|
||||
@@ -31,6 +31,7 @@ function sharedEnv() {
|
||||
},
|
||||
},
|
||||
'../../ui/dashboard-settings': settings,
|
||||
'./translate-settings': { translateModelSetting: { get: () => translationModel } },
|
||||
'../../prompts': {
|
||||
CALCULATOR_REWRITE_SYSTEM_PROMPT: 'calculator system',
|
||||
buildCalculatorRewriteUserMessage: spoken => `rewrite: ${spoken}`,
|
||||
@@ -84,3 +85,25 @@ test('Translate resolves and streams through the compatible provider without cha
|
||||
assert.deepEqual(answers, ['Hello']);
|
||||
assert.deepEqual(errors, []);
|
||||
});
|
||||
|
||||
test('Translate overrides the model without changing Assistant configuration', () => {
|
||||
const env = sharedEnv({ translationModel: ' gpt-4o-mini ', openAiKey: 'openai-key', assistantModel: 'terra' });
|
||||
const { resolveTranslationModel } = env.load('app/apps/translate/translate-llm.ts');
|
||||
const model = resolveTranslationModel();
|
||||
assert.equal(model.provider, 'openai');
|
||||
assert.equal(model.model, 'gpt-4o-mini');
|
||||
assert.equal(model.apiKey, 'openai-key');
|
||||
assert.equal(model.effort, undefined, 'do not send Assistant reasoning options to the custom model');
|
||||
});
|
||||
|
||||
test('Translate override requires the OpenAI key and does not silently fall back', () => {
|
||||
const env = sharedEnv({ translationModel: 'gpt-4o-mini' });
|
||||
assert.equal(env.load('app/apps/translate/translate-llm.ts').resolveTranslationModel(), null);
|
||||
});
|
||||
|
||||
test('Whitespace-only Translate override preserves Assistant routing', () => {
|
||||
const env = sharedEnv({ translationModel: ' ' });
|
||||
const model = env.load('app/apps/translate/translate-llm.ts').resolveTranslationModel();
|
||||
assert.equal(model.provider, 'openai-compatible');
|
||||
assert.equal(model.model, 'compatible-model');
|
||||
});
|
||||
@@ -23,6 +23,7 @@ function settingsHarness({ main = 'onboard', setUp = [] } = {}) {
|
||||
'../../ui/dashboard-settings': {
|
||||
ConfigSettingEnum: Setting,
|
||||
ConfigSettingBoolean: Setting,
|
||||
ConfigSettingString: Setting,
|
||||
voiceProviderSetting: {
|
||||
get: () => main,
|
||||
isDisabled: provider => !available.has(provider),
|
||||
|
||||
Reference in new issue
Block a user