From 386a10775d06c0bb920080319c36f0ec3adeb540 Mon Sep 17 00:00:00 2001 From: MasterControl Date: Mon, 16 Nov 2026 18:32:34 +0000 Subject: [PATCH] Revert "fix: show silent-mode feedback and promptly detect exit" This reverts commit 02dba881317d8d2768f0593ffe8b5c2893cf814d. --- app/g2/dashboard-controller.ts | 50 +------------- app/phone-ui/main-page.xml | 3 - app/phone-ui/main-view-model.ts | 13 ---- docs/validation-silent-mode.md | 13 ---- .../app/g2protocol/ConnectionOptions.kt | 2 - .../g2protocol/session/GlassesSessionSend.kt | 5 +- .../faceclaw/app/GlassesSessionCoreTest.kt | 18 ----- tests/silent-mode-feedback.test.cjs | 67 ------------------- 8 files changed, 5 insertions(+), 166 deletions(-) delete mode 100644 docs/validation-silent-mode.md delete mode 100644 tests/silent-mode-feedback.test.cjs diff --git a/app/g2/dashboard-controller.ts b/app/g2/dashboard-controller.ts index 934be105..6e441fdf 100644 --- a/app/g2/dashboard-controller.ts +++ b/app/g2/dashboard-controller.ts @@ -120,7 +120,6 @@ export type DashboardSnapshot = { * glasses, and this says which harmless thing is actually going on. */ displayPreviewMessage: string; - silentModeFeedback: string; activeTextSettingId: string | null; activeTextEditorTitle: string; activeTextSettingTitle: string; @@ -296,9 +295,6 @@ class DashboardController { /** The screen area displayPreview shows (Preview scaling), or null for the whole panel. */ private displayPreviewCrop: ScreenRect | null = null; private silentMode = false; - private silentModeFeedback = ""; - private silentModeFeedbackGeneration = 0; - private silentModeFeedbackTimer: ReturnType | null = null; // Brightness value last pushed to the glasses; see pushBrightness. private lastPushedBrightness: string | null = null; private lastPushedHeadUp: string | null = null; @@ -1221,7 +1217,6 @@ class DashboardController { status: this.status, displayPreview: this.displayPreview, displayPreviewMessage: this.displayPreviewMessage(), - silentModeFeedback: this.silentModeFeedback, activeTextSettingId: primaryTextSetting?.id ?? null, activeTextEditorTitle: this.activeTextEditorTitle, activeTextSettingTitle: primaryTextSetting?.editorTitle ?? "", @@ -1260,43 +1255,6 @@ class DashboardController { * charging and silent mode both make the display unavailable while BLE stays * up, and a battery that just ran out simply stops answering. */ - private handleSilentMode(silent: boolean): void { - if (this.silentMode === silent) return; - this.silentMode = silent; - const generation = ++this.silentModeFeedbackGeneration; - if (this.silentModeFeedbackTimer !== null) clearTimeout(this.silentModeFeedbackTimer); - this.silentModeFeedbackTimer = null; - this.silentModeFeedback = silent - ? "Silent mode enabled — hold both touchpads to exit" - : "Silent mode disabled"; - if (!silent) { - void this.showSilentModeExit(generation).catch(error => { - this.appendLog(`silent-mode exit feedback failed: ${this.formatError(error)}`); - }); - this.silentModeFeedbackTimer = setTimeout(() => { - this.silentModeFeedbackTimer = null; - this.silentModeFeedback = ""; - this.emit(); - }, 5000); - } - this.emit(); - } - - private async showSilentModeExit(generation: number): Promise { - if (this.phase !== "connected" || this.silentMode || this.glassesLocked) return; - // The firmware powered the lenses down, and Faceclaw may have gone to - // sleep/suspended EvenHub meanwhile. Reusing the ordinary wake barrier is - // essential: rendering an alert into the retained surface alone is invisible. - this.cancelEvenHubSuspendTimer(); - shell.wake("sidebar"); - const ready = await this.ensureEvenHubSessionActive(); - if (!ready || generation !== this.silentModeFeedbackGeneration || this.silentMode || - this.phase !== "connected" || this.glassesLocked) return; - shell.showAlert("Silent mode disabled"); - shell.foregroundWindow()?.requestRender(); - this.requestShellRender(); - } - private displayPreviewMessage(): string { if (this.phase === "charging") { return chargingPreviewMessage(this.glassesDisplayState()); @@ -1731,7 +1689,9 @@ class DashboardController { }); }); this.offSilentMode = communicator.onSilentMode((silent) => { - this.handleSilentMode(silent); + if (this.silentMode === silent) return; + this.silentMode = silent; + this.emit(); }); this.offWearState = communicator.onWearState((wearing) => { this.handleWearState(wearing); @@ -3129,10 +3089,6 @@ class DashboardController { // Kept across "connecting": silent mode blocks app launches, so it can // itself cause the reconnect churn, and Java re-reports it either way. this.silentMode = false; - this.silentModeFeedbackGeneration++; - if (this.silentModeFeedbackTimer !== null) clearTimeout(this.silentModeFeedbackTimer); - this.silentModeFeedbackTimer = null; - this.silentModeFeedback = ""; } this.emit(); } diff --git a/app/phone-ui/main-page.xml b/app/phone-ui/main-page.xml index 10833a6a..29c12f08 100644 --- a/app/phone-ui/main-page.xml +++ b/app/phone-ui/main-page.xml @@ -74,9 +74,6 @@ class="ble-bandwidth-indicator" horizontalAlignment="center" verticalAlignment="bottom" /> -