forked from Blendman974/faceclaw
feat: choose translation output language independently
This commit is contained in:
8 files changed
+81
-27
No files matched your search
@@ -2,7 +2,7 @@ const test = require('node:test');
|
||||
const assert = require('node:assert/strict');
|
||||
const { loader } = require('./helpers/load-typescript.cjs');
|
||||
|
||||
function sharedEnv({ translationModel = '', openAiKey = '', assistantModel = 'openai-compatible' } = {}) {
|
||||
function sharedEnv({ translationModel = '', targetLanguage = 'en', openAiKey = '', assistantModel = 'openai-compatible' } = {}) {
|
||||
const compatible = [], unexpected = [];
|
||||
const localLlm = {
|
||||
streamLocalModel: () => unexpected.push('local'),
|
||||
@@ -31,12 +31,16 @@ function sharedEnv({ translationModel = '', openAiKey = '', assistantModel = 'op
|
||||
},
|
||||
},
|
||||
'../../ui/dashboard-settings': settings,
|
||||
'./translate-settings': { translateModelSetting: { get: () => translationModel } },
|
||||
'./translate-settings': {
|
||||
translateModelSetting: { get: () => translationModel },
|
||||
translateTargetLanguageSetting: { get: () => targetLanguage },
|
||||
spokenLanguageName: code => ({ en: 'English', fr: 'French' })[code],
|
||||
},
|
||||
'../../prompts': {
|
||||
CALCULATOR_REWRITE_SYSTEM_PROMPT: 'calculator system',
|
||||
buildCalculatorRewriteUserMessage: spoken => `rewrite: ${spoken}`,
|
||||
TRANSLATE_SYSTEM_PROMPT: 'translate system',
|
||||
buildTranslateUserMessage: speech => `translate: ${speech}`,
|
||||
buildTranslateSystemPrompt: language => `translate system: ${language}`,
|
||||
buildTranslateUserMessage: (speech, context, language, target) => `translate: ${speech} into ${target}`,
|
||||
},
|
||||
});
|
||||
return { load, compatible, unexpected };
|
||||
@@ -78,7 +82,7 @@ test('Translate resolves and streams through the compatible provider without cha
|
||||
assert.equal(options.baseUrl, 'https://provider.example/api/v1');
|
||||
assert.equal(options.model, 'compatible-model');
|
||||
assert.equal(options.maxTokens, 1024);
|
||||
assert.equal(options.messages[0].content, 'translate: Hola');
|
||||
assert.equal(options.messages[0].content, 'translate: Hola into English');
|
||||
options.onTextDelta('Hello', '<english>Hello</english>');
|
||||
options.onDone({ text: '<english>Hello</english>', content: [], stopReason: 'end_turn' });
|
||||
assert.deepEqual(progress, ['Hello']);
|
||||
@@ -107,3 +111,13 @@ test('Whitespace-only Translate override preserves Assistant routing', () => {
|
||||
assert.equal(model.provider, 'openai-compatible');
|
||||
assert.equal(model.model, 'compatible-model');
|
||||
});
|
||||
|
||||
test('Translate streams with the selected output language in both prompts', () => {
|
||||
const env = sharedEnv({ targetLanguage: 'fr' });
|
||||
const { resolveTranslationModel, streamTranslation } = env.load('app/apps/translate/translate-llm.ts');
|
||||
streamTranslation(resolveTranslationModel(), {
|
||||
speech: 'Hello', context: [], language: 'English', onProgress() {}, onDone() {}, onError() {},
|
||||
});
|
||||
assert.equal(env.compatible[0].system, 'translate system: French');
|
||||
assert.equal(env.compatible[0].messages[0].content, 'translate: Hello into French');
|
||||
});
|
||||
@@ -209,7 +209,7 @@ test('the user message carries earlier turns as context, then the speech', () =>
|
||||
assert.equal(buildTranslateUserMessage('Hola', []), 'Translate this speech into English:\n<speech>Hola</speech>');
|
||||
const message = buildTranslateUserMessage('¿Y tú?', [{ source: 'Bien', translation: 'Fine' }]);
|
||||
assert.match(message, /context only/);
|
||||
assert.match(message, /<speech>Bien<\/speech>\n<english>Fine<\/english>\n\nTranslate this speech/);
|
||||
assert.match(message, /<speech>Bien<\/speech>\n<translation>Fine<\/translation>\n\nTranslate this speech/);
|
||||
assert.ok(message.endsWith('<speech>¿Y tú?</speech>'));
|
||||
assert.equal(buildTranslateUserMessage('こんにちは', [], 'Japanese'),
|
||||
'Translate this Japanese speech into English:\n<speech>こんにちは</speech>');
|
||||
@@ -249,5 +249,27 @@ test('the spoken language defaults to auto-detect and resolves to an ISO 639-1 c
|
||||
assert.equal(settings.spokenLanguageName('ja'), 'Japanese');
|
||||
assert.equal(settings.translateLanguageSetting.values[0], 'auto');
|
||||
assert.ok(settings.translateLanguageSetting.values.slice(1).every(code => /^[a-z]{2}$/.test(code)));
|
||||
assert.equal(settings.translateLanguageSetting.values.includes('en'), false, 'English is the target, not a source');
|
||||
assert.equal(settings.translateLanguageSetting.values.includes('en'), true, 'English can be a source when translating into another language');
|
||||
});
|
||||
|
||||
test('output language defaults to English and is independent of spoken language', () => {
|
||||
const settings = settingsHarness();
|
||||
assert.equal(settings.translateTargetLanguageSetting.get(), 'en');
|
||||
settings.translateTargetLanguageSetting.set('fr');
|
||||
assert.equal(settings.translateTargetLanguageSetting.displayValue(), 'French');
|
||||
assert.equal(settings.resolveTranslateLanguage(), '');
|
||||
settings.translateLanguageSetting.set('en');
|
||||
assert.equal(settings.resolveTranslateLanguage(), 'en');
|
||||
assert.equal(settings.translateTargetLanguageSetting.get(), 'fr');
|
||||
});
|
||||
|
||||
test('both translation prompts request the selected output language', () => {
|
||||
const { buildTranslateSystemPrompt } = loader()('app/prompts.ts');
|
||||
const system = buildTranslateSystemPrompt('French');
|
||||
assert.match(system, /fluent French/);
|
||||
assert.doesNotMatch(system, /English/);
|
||||
const message = buildTranslateUserMessage('Hello', [{ source: 'Thanks', translation: 'Merci' }], 'English', 'French');
|
||||
assert.match(message, /English speech into French/);
|
||||
assert.match(message, /<translation>Merci<\/translation>/);
|
||||
assert.doesNotMatch(message, /<english>/);
|
||||
});
|
||||
Reference in new issue
Block a user