forked from Blendman974/faceclaw
Merge branch 'main' of https://github.com/jimrandomh/faceclaw
This commit is contained in:
commit
0217d4b1ea
1 file changed
+18
-4
@@ -2537,6 +2537,19 @@ class DashboardController {
|
|||||||
this.pendingShellRenderCauseFrameId = 0;
|
this.pendingShellRenderCauseFrameId = 0;
|
||||||
const frameId = frameTimings.startFrame("render:shell", causeFrameId);
|
const frameId = frameTimings.startFrame("render:shell", causeFrameId);
|
||||||
frameTimings.annotateFrame(frameId, shell.describeInputTarget());
|
frameTimings.annotateFrame(frameId, shell.describeInputTarget());
|
||||||
|
// Nothing to send a frame to: stop here, BEFORE painting. This check used
|
||||||
|
// to run only after the paint, which made a no-display state a
|
||||||
|
// main-thread busy loop: paint (~55 ms) -> endRenderPass reports stale
|
||||||
|
// data -> requestShellRender re-queues (shellRenderQueued, since a render
|
||||||
|
// is in progress) -> the display check discards the work -> the do/while
|
||||||
|
// in requestShellRender goes straight round again. Measured on a device
|
||||||
|
// with the glasses not presenting: 40 of 40 frames discarded, ~19 a
|
||||||
|
// second, enough to starve input and ANR. Leaving early costs nothing and
|
||||||
|
// breaks the loop, because the re-request lives downstream of this point.
|
||||||
|
if (!this.display || this.phase === "charging") {
|
||||||
|
frameTimings.finishFrame(frameId, "discarded: shell render with no display target");
|
||||||
|
return;
|
||||||
|
}
|
||||||
const wantFreshData = this.nextShellRenderWantsFreshData;
|
const wantFreshData = this.nextShellRenderWantsFreshData;
|
||||||
this.nextShellRenderWantsFreshData = false;
|
this.nextShellRenderWantsFreshData = false;
|
||||||
if (wantFreshData) frameTimings.logFrame(frameId, "follow-up repaint that must not use cached data");
|
if (wantFreshData) frameTimings.logFrame(frameId, "follow-up repaint that must not use cached data");
|
||||||
@@ -2555,11 +2568,12 @@ class DashboardController {
|
|||||||
this.nextShellRenderWantsFreshData = true;
|
this.nextShellRenderWantsFreshData = true;
|
||||||
this.requestShellRender(frameId);
|
this.requestShellRender(frameId);
|
||||||
}
|
}
|
||||||
|
// The display-target check that used to live here now runs before the
|
||||||
|
// paint, at the top of this function. Nothing between the two can change
|
||||||
|
// it -- paintScene is synchronous and there is no await in between -- so
|
||||||
|
// repeating it here is dead code, and the compiler agrees: the early
|
||||||
|
// return narrows this.phase, making the "charging" comparison impossible.
|
||||||
const display = this.display;
|
const display = this.display;
|
||||||
if (!display || this.phase === "charging") {
|
|
||||||
frameTimings.finishFrame(frameId, "discarded: shell render with no display target");
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
await frameTimings.spanAsync(frameId, "submit", () => display.submitShellScene(planes, paintMs, frameId));
|
await frameTimings.spanAsync(frameId, "submit", () => display.submitShellScene(planes, paintMs, frameId));
|
||||||
// Backpressure: the next shell render waits for this one to reach the
|
// Backpressure: the next shell render waits for this one to reach the
|
||||||
// glasses. Timing out here means the loop was blocked for the full timeout
|
// glasses. Timing out here means the loop was blocked for the full timeout
|
||||||
|
|||||||
Reference in new issue
Block a user