From 8be15d890c19a034553b90da61bd5d8ec9848dcc Mon Sep 17 00:00:00 2001 From: Guillaume ETHEVE Date: Fri, 6 Nov 2026 06:33:47 +0100 Subject: [PATCH] fix: hide switcher move action for temporary windows --- app/ui/shell/shell.ts | 3 ++- tests/switcher-order.test.cjs | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/app/ui/shell/shell.ts b/app/ui/shell/shell.ts index d6c33163..d88b01a1 100644 --- a/app/ui/shell/shell.ts +++ b/app/ui/shell/shell.ts @@ -1996,7 +1996,8 @@ class Shell { }, }]), ); - if (foreground.closeable && this.switcherWindows().filter(window => window.closeable).length > 1) { + const movableWindows = this.switcherWindows().filter(window => window.closeable); + if (movableWindows.length > 1 && movableWindows.includes(foreground)) { items.push({ label: "Move in app switcher", description: "Choose this open window's position in the app switcher.", diff --git a/tests/switcher-order.test.cjs b/tests/switcher-order.test.cjs index b28c541a..84ad1ff2 100644 --- a/tests/switcher-order.test.cjs +++ b/tests/switcher-order.test.cjs @@ -118,6 +118,9 @@ test('temporary status windows and pinned slots stay fixed, including selected s assert.deepEqual(h.ids(), ['launcher', 'terminal:two', 'notifications:temporary', 'another-pinned', 'calendar', 'terminal:one']); assert.equal(h.s.foregroundWindow(), hidden); assert.equal(h.s.selectedStatus.host, hidden); + h.s.openEscapeMenu(); + assert.ok(!h.menu().items.some(item => item.label === 'Move in app switcher')); + h.s.stack.pop(); h.s.openSwitcherMoveMenu(h.first.windowId); assert.deepEqual(Array.from(h.menu().items, item => item.label), ['1. Terminal', '2. Calendar', '3. Terminal']); });